Release 1.2.58 - #2192
Conversation
WalkthroughThis is a version bump release from 1.2.57 to 1.2.58 that updates version numbers across configuration files, documentation, and tests. The release introduces new public methods in ARTClientInformation for constructing and managing platform and library agent identifiers. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Source/ARTClientInformation.m (1)
41-49:⚠️ Potential issue | 🟠 MajorUse string equality instead of pointer identity comparison for the sentinel.
The
version == ARTClientInformationAgentNotVersionedcheck relies on pointer identity, which is fragile when the value flows through Swift-Objective-C bridging. UseisEqualToString:to ensure reliable comparison regardless of how the NSString instance originates.Proposed fix
- if (version == ARTClientInformationAgentNotVersioned) { + if ([version isEqualToString:ARTClientInformationAgentNotVersioned]) { [components addObject:name]; } else { [components addObject:[NSString stringWithFormat:@"%@/%@", name, version]]; }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Source/ARTClientInformation.m` around lines 41 - 49, The code currently compares NSString instances by pointer identity; change the sentinel check in the agent-string building loop to use string equality: replace the `version == ARTClientInformationAgentNotVersioned` comparison with an `isEqualToString:` call (i.e., test `[version isEqualToString:ARTClientInformationAgentNotVersioned]`) when constructing components in the loop that iterates over `sortedAgentNames` and uses `version` and `ARTClientInformationAgentNotVersioned`.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@Source/ARTClientInformation.m`:
- Around line 41-49: The code currently compares NSString instances by pointer
identity; change the sentinel check in the agent-string building loop to use
string equality: replace the `version == ARTClientInformationAgentNotVersioned`
comparison with an `isEqualToString:` call (i.e., test `[version
isEqualToString:ARTClientInformationAgentNotVersioned]`) when constructing
components in the loop that iterates over `sortedAgentNames` and uses `version`
and `ARTClientInformationAgentNotVersioned`.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (10)
CHANGELOG.mdREADME.mdScripts/jazzy.shSource/ARTClientInformation.mTest/AblyTests/Tests/ARTDefaultTests.swiftTest/AblyTests/Tests/ClientInformationTests.swiftTest/AblyTests/Tests/RealtimeClientConnectionTests.swiftTest/AblyTests/Tests/RestClientTests.swiftTest/AblyTests/Tests/WrapperSDKProxyTests.swiftVersion.xcconfig
Summary
Changes in this release
Full Changelog: 1.2.57...1.2.58
Summary by CodeRabbit
New Features
Chores